Panel scrollbar update #726
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reflow functions now use the *ContentRegion* Width instead of the Width of the Panel - Default Scrollbar Padding is 4 px - to handle panels inside panels which use FILL to be sized correctly some scrollbar properties have been moved up from (Flow)Panel to Container - Content Regions only resize to their VISIBILE childs size instead of accounting for any which resulted in panels to not grow back to smaller sizes when hiding bigger controls - Scrollbar now returns the _barBounds.Width instead of the _textureBar.Width
BillChirico
reviewed
Sep 1, 2022
| @@ -146,6 +196,7 @@ public abstract class Container : Control, IEnumerable<Control> { | |||
|
|
|||
| public bool AddChild(Control child) { | |||
| if (_children.Contains(child)) return true; | |||
| if (_panelScrollbar != null && child == _panelScrollbar) return true; | |||
There was a problem hiding this comment.
Can be shortened to
return _panelScrollbar != null && child == _panelScrollbar
There was a problem hiding this comment.
Wouldn't that return always and not continue to add the child?
|
Can you please include a description of all of the changes or provide a link to a full summary of where you've described it in Discord? |
|
I'm seeing weird issues with many of the containers. This is a bit confusing with how it appears to be modifying the content region. |
Container.csProperties:
Methods:
Scrollbar.csProperties:
Panel.csMethods:
UpdateScrollbar
FlowPanel.csMethods:
|
|
moved to #749 for a cleaner PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.